impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zach Amsden (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5127: Add history max option
Date Fri, 07 Apr 2017 01:36:41 GMT
Zach Amsden has posted comments on this change.

Change subject: IMPALA-5127: Add history_max option
......................................................................


Patch Set 2:

(1 comment)

I made this a bit more friendly and tolerant as well.

http://gerrit.cloudera.org:8080/#/c/6335/2/shell/impala_shell.py
File shell/impala_shell.py:

Line 183:         self.readline.set_history_length(int(options.history_max))
> It would be nice to produce a human-friendly error message. I get the follo
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/6335
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf65bbecb8fd7f1105aac62b6745d6125a603d7f
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden <zamsden@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message