impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zach Amsden (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5180: Don't balk at non-deterministic exprs
Date Fri, 07 Apr 2017 00:50:21 GMT
Zach Amsden has posted comments on this change.

Change subject: IMPALA-5180: Don't balk at non-deterministic exprs
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6575/1/fe/src/main/java/org/apache/impala/analysis/Expr.java
File fe/src/main/java/org/apache/impala/analysis/Expr.java:

Line 1053:     if (slotIds == null || slotIds.size() == 0) return false;
This was a horrible mistake.  The result was that Hdfs tables with no partitions attached
every conjunct to an HdfsPartitionFilter.  This invoked a demon lying deep in the code where
expressions involving nested types that get evaluated in the context of a partition filter
are all non-constant and cause HdfsPartitionFilter to vomit blood.


-- 
To view, visit http://gerrit.cloudera.org:8080/6575
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I91054c6bf017401242259a1eff5e859085285546
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden <zamsden@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message