impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5173: crash with hash join feeding directly into nlj
Date Thu, 06 Apr 2017 21:36:59 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5173: crash with hash join feeding directly into nlj
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

Carry +2

http://gerrit.cloudera.org:8080/#/c/6568/2/be/src/exec/nested-loop-join-builder.cc
File be/src/exec/nested-loop-join-builder.cc:

Line 55:     // accounting, so also copy data in that cases to avoid stealing reservation
> Yeah, let's update the comment to be less contradictory.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/6568
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0c04952e591d17e5ff7e994884be4c4c899ae192
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message