impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5173: crash with hash join feeding directly into nlj
Date Thu, 06 Apr 2017 21:02:29 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-5173: crash with hash join feeding directly into nlj
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6568/2/be/src/exec/nested-loop-join-builder.cc
File be/src/exec/nested-loop-join-builder.cc:

Line 55:     // data in that cases. TODO: remove workaround when IMPALA-4179 is fixed
> Yeah when the block gets attached the batch has control over deletion, but 
Yeah, let's update the comment to be less contradictory.
otherwise, okay, we can use this for now and revisit with 4179 (though 4179 itself probably
needs some more thought).


-- 
To view, visit http://gerrit.cloudera.org:8080/6568
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0c04952e591d17e5ff7e994884be4c4c899ae192
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message