impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4817: Populate Parquet Statistics for Strings
Date Thu, 06 Apr 2017 12:35:36 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-4817: Populate Parquet Statistics for Strings
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6563/1/be/src/exec/hdfs-parquet-scanner.cc
File be/src/exec/hdfs-parquet-scanner.cc:

Line 559:     if (!ColumnStatsBase::ReadFromThrift(*thrift_stats, col_type, slot)) continue;
Once parquet-format PR #46 has been merged, we need to pass the file_meta_data.column_orders
to determine whether we want to read the min/max statistics as signed or unsigned. They could
be unsigned and exceed the datatype we're using, in which case we'd currently probably want
to error (since we don't seem to support logical types except for decimal).


-- 
To view, visit http://gerrit.cloudera.org:8080/6563
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3ef4a5d25a57c82577fd498d6d1c4297ecf39312
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message