impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler
Date Wed, 05 Apr 2017 22:40:18 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4086: Add benchmark for simple scheduler
......................................................................


Patch Set 5:

(3 comments)

This is still just benchmarking ComputeScanRangeAssignment(), right, not the whole Schedule()
method. That seems reasonable to me, but it seems like there was some back-and-forth earlier.

http://gerrit.cloudera.org:8080/#/c/4554/5/be/src/benchmarks/scheduler-benchmark.cc
File be/src/benchmarks/scheduler-benchmark.cc:

Line 18: #include <gutil/strings/substitute.h>
Nit: I personally think we should treat gutil as being part of our source tree, so it should
go below and be quoted with ""


PS5, Line 46: Blocks and block
This doesn't seem right.


http://gerrit.cloudera.org:8080/#/c/4554/5/be/src/scheduling/scheduler.h
File be/src/scheduling/scheduler.h:

Line 346:   Status ComputeScanRangeAssignment(QuerySchedule* schedule);
What do you think about adding a comment here, or maybe in the .cc pointing to the benchmark,
so that it's more discoverable for new people working on the code.


-- 
To view, visit http://gerrit.cloudera.org:8080/4554
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I89ec1c6c1828bb0b86d1e13ce4dfc5a8df865c2e
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: anujphadke <aphadke@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message