impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-1726: Treat parquet ENUMs as STRINGs when creating tables.
Date Wed, 05 Apr 2017 07:58:24 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-1726: Treat parquet ENUMs as STRINGs when creating tables.
......................................................................


Patch Set 1:

(1 comment)

Thank you for working on this. Have you already thought about how we could test this? You
can have a look at testdata/workloads/functional-query/queries/QueryTest/create-table-like-file.test,
but I'm unsure whether we have a parquet file with an ENUM in our testdata already. Let me
know if you get stuck there and we can figure out how to add one.

http://gerrit.cloudera.org:8080/#/c/6550/1//COMMIT_MSG
Commit Message:

PS1, Line 7: IMPALA-1726
IMPALA-2525?


-- 
To view, visit http://gerrit.cloudera.org:8080/6550
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7a2e20c3ab83eb3fac422c3b33c117856fec475
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jakub Kukul <jakub.kukul@gmail.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message