impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5156: Drop VLOG level passed into Kudu client
Date Tue, 04 Apr 2017 22:44:02 GMT
Hello Henry Robinson,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/6549

to look at the new patch set (#2).

Change subject: IMPALA-5156: Drop VLOG level passed into Kudu client
......................................................................

IMPALA-5156: Drop VLOG level passed into Kudu client

The Kudu logging is very verbose and all of the logging may
affect performance. This change reduces the Kudu client log
level to v-1, since Impala is typically run at v=1 and isn't
too noisy.

In some simple concurrency testing, Todd found that reducing
the vlog level resulted in an increase in throughput from
~17 qps to 60qps.

Change-Id: I6f160e20de37ac13887ccfebc5fb1d595fd05db1
---
M be/src/exec/kudu-util.cc
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/49/6549/2
-- 
To view, visit http://gerrit.cloudera.org:8080/6549
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6f160e20de37ac13887ccfebc5fb1d595fd05db1
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>

Mime
View raw message