impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brown (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4643: [DOCS] Change URLs / set up keydefs for JIRA reports
Date Tue, 04 Apr 2017 21:31:13 GMT
Michael Brown has posted comments on this change.

Change subject: IMPALA-4643: [DOCS] Change URLs / set up keydefs for JIRA reports
......................................................................


Patch Set 2:

(5 comments)

I still think the anchor should just be removed, because it adds a broken link, instead of
preserving a broken link. I also found a few other places where direct links are used, not
the xrefs. If there's a good reason for not using xrefs, that's fine.

http://gerrit.cloudera.org:8080/#/c/6515/1/docs/topics/impala_fixed_issues.xml
File docs/topics/impala_fixed_issues.xml:

PS1, Line 573: <xref href="impala_fixed_issues.xml#fixed_issues_232"/>
> Done
I believe a user reading these docs will click the anchor and it will go nowhere. It seems
like on LHS, there is no link to click. Thus this patch (RHS) introduces a dead link. I would
suggest you revert this change and add a follow-on Jira to fix the link.


http://gerrit.cloudera.org:8080/#/c/6515/2/docs/topics/impala_fixed_issues.xml
File docs/topics/impala_fixed_issues.xml:

Line 2590:         <xref href="https://issues.apache.org/jira/issues/?jql=project%3Dimpala+and+fixVersion%3D%22Impala+2.1%22+and+resolution%3D%22Fixed%22"
format="html" scope="external">
Why not jira_list_210?


Line 5036:         <xref href="https://issues.apache.org/jira/issues/?jql=project%3Dimpala+and+fixVersion%3D%22Impala+1.1%22+and+resolution%3D%22Fixed%22"
format="html" scope="external">
Why not jira_list_110 (or some other good name)?


Line 5168:         <xref href="https://issues.apache.org/jira/issues/?jql=project%3Dimpala+and+fixVersion%3D%22Impala+1.0.1%22+and+resolution%3D%22Fixed%22"
format="html" scope="external">
Why not jira_list_101?


Line 5403:         <xref href="https://issues.apache.org/jira/issues/?jql=project+%3D+impala+AND+resolution+%3D+Fixed+AND+fixVersion+%3D+%22Impala+1.0%22+ORDER+BY+key+ASC%2C+assignee+ASC%2C+priority+DESC"
scope="external" format="html">this
Why not jira_list_100?


-- 
To view, visit http://gerrit.cloudera.org:8080/6515
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I007e634f9da57289674683dd5bf64e3e3ca8f525
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Laurel Hale <laurel@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message