impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5108: [DOCS] Explain 50% margin for idle * settings
Date Tue, 04 Apr 2017 20:20:13 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-5108: [DOCS] Explain 50% margin for idle_* settings
......................................................................


Patch Set 1:

(3 comments)

Looks pretty good - just a couple of nits.

http://gerrit.cloudera.org:8080/#/c/6463/1/docs/topics/impala_timeouts.xml
File docs/topics/impala_timeouts.xml:

Line 116:             query option. Any value specified for the <codeph>--idle_query_timeout</codeph>
startup
non-zero? If it's zero, the default timeout is effectively infinite.


PS1, Line 141: and queries
I just looked - queries are checked every second.


PS1, Line 141: To avoid excessive polling, 
No need to add justification.


-- 
To view, visit http://gerrit.cloudera.org:8080/6463
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0b19912dac1df13bfcbcb67f0bd4ed0064ad8db9
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <jeszyb@gmail.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message