impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5137: Support Kudu UNIXTIME MICROS as Impala TIMESTAMP
Date Tue, 04 Apr 2017 17:04:49 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP
......................................................................


Patch Set 1:

(2 comments)

> Did you mean to update the patch?

Yeah, but I need to iron out a few more things and add a few more tests. I was waiting to
see if I'd get David's API changes for the read path soon, but it sounds like I wont so I'll
get this patch cleaned up w/ just the write path for the time being.

http://gerrit.cloudera.org:8080/#/c/6526/1//COMMIT_MSG
Commit Message:

PS1, Line 11: Impala's TIMESTAMP type is
> Impala stores TIMESTAMP values internally as... ?
Done


PS1, Line 14: will is
> just "is"?
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/6526
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae6ccfffb79118a9036fb2227dba3a55356c896d
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message