impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4893: Efficiently update the rows read counter for sequence file
Date Mon, 03 Apr 2017 22:21:07 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4893: Efficiently update the rows read counter for sequence file
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

Looks good to me. Did you run the modified scanner tests for all the exhaustive file formats?
I'll run that myself before merging.

http://gerrit.cloudera.org:8080/#/c/6522/2/be/src/exec/hdfs-sequence-scanner.cc
File be/src/exec/hdfs-sequence-scanner.cc:

Line 345:     if (stream_->eof()) {
We put simple "if" statements on one like (https://google.github.io/styleguide/cppguide.html#Conditionals)

  if (stream_->eof()) break;


-- 
To view, visit http://gerrit.cloudera.org:8080/6522
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie42c97a36e46172884cc497aa645036c2c11f541
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: anujphadke <aphadke@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: anujphadke <aphadke@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message