impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5031: Remove undefined behavior: left shift into the sign bit
Date Sat, 01 Apr 2017 14:41:28 GMT
Jim Apple has posted comments on this change.

Change subject: IMPALA-5031: Remove undefined behavior: left shift into the sign bit
......................................................................


Patch Set 1:

> Out of curiosity, how did you find these?

http://releases.llvm.org/3.8.0/tools/clang/docs/UndefinedBehaviorSanitizer.html

https://github.com/apache/incubator-impala/commit/93eb8ccbedda060af01dccbb452c28d8f2072115

http://jenkins.impala.io:8080/job/ubuntu-14.04-from-scratch/1072/

-- 
To view, visit http://gerrit.cloudera.org:8080/6528
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I748697cf503e9e717a6e95250c2cbbf031c6352d
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message