impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-5137: Support Kudu UNIXTIME MICROS as Impala TIMESTAMP
Date Sat, 01 Apr 2017 12:12:19 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP

Patch Set 1:

Commit Message:

PS1, Line 11: Impala's TIMESTAMP type is
Impala stores TIMESTAMP values internally as... ?

PS1, Line 14: will is
just "is"?
File be/src/exec/

Line 29: #include "runtime/timestamp-value.h"
Why is this needed?
File be/src/runtime/

PS1, Line 596: 17987443200
These values all look special but it's hard to tell why they are like that. Could you make
them named constants? Or add a comment?
File be/src/runtime/timestamp-value.h:

PS1, Line 201: reinterpret_cast<int64_t>
Will this work if time_t is 32bit? I think static_cast<>() would be the preferred way.
File fe/src/main/java/org/apache/impala/util/

Line 151:       //  TODO: Can't support timestamps in the key until FE can convert to unixtime
Will you address this in your change? If not, can you create a JIRA?
File tests/query_test/

Line 112:         (cast("1970-01-01 00:00:00" as timestamp)),
nit: Make all keywords the same case (upper or lower).

Line 113:         (cast("1970-01-01 00:00:00" as timestamp) + interval 1 microsecond)
Can you add a timestamp before the epoch (so it'd be negative), and one in 2039 (to check
for overflows)?

PS1, Line 125: simle
nit simple

I think you can pass tzinfo as the last parameter of datetime():

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae6ccfffb79118a9036fb2227dba3a55356c896d
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Lars Volker <>
Gerrit-Reviewer: Matthew Jacobs <>
Gerrit-HasComments: Yes

View raw message