Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 107D3200C32 for ; Thu, 9 Mar 2017 18:18:15 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 0D3A8160B75; Thu, 9 Mar 2017 17:18:15 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5DA92160B5F for ; Thu, 9 Mar 2017 18:18:14 +0100 (CET) Received: (qmail 36734 invoked by uid 500); 9 Mar 2017 17:18:13 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 36723 invoked by uid 99); 9 Mar 2017 17:18:12 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Mar 2017 17:18:12 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 506D01A005B for ; Thu, 9 Mar 2017 17:18:12 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id wC8LMZpqhOfF for ; Thu, 9 Mar 2017 17:18:11 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 62BC060DBE for ; Thu, 9 Mar 2017 17:18:11 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v29HI5Ri014628; Thu, 9 Mar 2017 17:18:05 GMT Date: Thu, 9 Mar 2017 17:18:05 +0000 From: "Joe McDonnell (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org Message-ID: Reply-To: joemcdonnell@cloudera.com X-Gerrit-MessageType: newchange Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5055=3A_Fix_DCHECK_in_parquet-column-readers=2Ecc_ReadPageHeader=28=29=0A?= X-Gerrit-Change-Id: Ie22a8cf6b53f507c378c2efe302482409935184e X-Gerrit-ChangeURL: X-Gerrit-Commit: 832f058b1898f69ee1cb298bd4f7487d3d6c354c MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Thu, 09 Mar 2017 17:18:15 -0000 Joe McDonnell has uploaded a new change for review. http://gerrit.cloudera.org:8080/6328 Change subject: IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader() ...................................................................... IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader() GetBytes only sets status in the case of an error. This means that ReadPageHeader needs to initialize the status variable so that the status.ok() check is accurate after the GetBytes call. I verified that the other uses of status are ok. Most do not check status.ok() directly, but rely on the return value of the function setting status. Change-Id: Ie22a8cf6b53f507c378c2efe302482409935184e --- M be/src/exec/parquet-column-readers.cc 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/28/6328/1 -- To view, visit http://gerrit.cloudera.org:8080/6328 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie22a8cf6b53f507c378c2efe302482409935184e Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell