Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 82F06200C3A for ; Fri, 31 Mar 2017 20:12:50 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 81919160B80; Fri, 31 Mar 2017 18:12:50 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C80BF160B7C for ; Fri, 31 Mar 2017 20:12:49 +0200 (CEST) Received: (qmail 82350 invoked by uid 500); 31 Mar 2017 18:12:48 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 82333 invoked by uid 99); 31 Mar 2017 18:12:48 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 31 Mar 2017 18:12:48 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 4AB29C0B57 for ; Fri, 31 Mar 2017 18:12:48 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id CRi55paO6cZU for ; Fri, 31 Mar 2017 18:12:47 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 588035FAD1 for ; Fri, 31 Mar 2017 18:12:47 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v2VICkow006006; Fri, 31 Mar 2017 18:12:46 GMT Message-Id: <201703311812.v2VICkow006006@ip-10-146-233-104.ec2.internal> Date: Fri, 31 Mar 2017 18:12:46 +0000 From: "Tim Armstrong (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Taras Bobrovytsky , Dan Hecht Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-3203=3A_Part_2=3A_per-core_free_lists_in_buffer_pool=0A?= X-Gerrit-Change-Id: I612bd1cd0f0e87f7d8186e5bedd53a22f2d80832 X-Gerrit-ChangeURL: X-Gerrit-Commit: 5ef40bbb357a72129bfe25989124d5bc287be2cf In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Fri, 31 Mar 2017 18:12:50 -0000 Tim Armstrong has posted comments on this change. Change subject: IMPALA-3203: Part 2: per-core free lists in buffer pool ...................................................................... Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/6414/13/be/src/runtime/bufferpool/buffer-allocator.h File be/src/runtime/bufferpool/buffer-allocator.h: Line 164: }; > I was thinking it might be useful to have information similar to what we ge We should chat about the design a bit. I added a couple of basic counters as part of the follow-up mmap patch: https://gerrit.cloudera.org/#/c/6474 We probably don't want to have global counters shared between all threads, but we could probably have per-arena counters aggregated on demand via a SumGauge. -- To view, visit http://gerrit.cloudera.org:8080/6414 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I612bd1cd0f0e87f7d8186e5bedd53a22f2d80832 Gerrit-PatchSet: 13 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes