Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201703311658.v2VGwHGI004516@ip-10-146-233-104.ec2.internal>
Date: Fri, 31 Mar 2017 16:58:17 +0000
From: "Jim Apple (Code Review)" <gerrit@cloudera.org>
To: Michael Brown <mikeb@cloudera.com>, impala-cr@cloudera.com,
        reviews@impala.incubator.apache.org
CC: Jim Apple <jbapple-impala@apache.org>
Reply-To: jbapple-impala@apache.org
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5140=3A_improve_docs_building_guidelines=0A?=
In-Reply-To: <gerrit.1490823226000.I71ae79ecd346045697fe225140ee9a317c5a337f@gerrit.cloudera.org>
References: <gerrit.1490823226000.I71ae79ecd346045697fe225140ee9a317c5a337f@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.7
archived-at: Fri, 31 Mar 2017 16:58:21 -0000

Jim Apple has posted comments on this change.

Change subject: IMPALA-5140: improve docs building guidelines
......................................................................


Patch Set 6:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/6512/5/docs/README.md
File docs/README.md:

PS5, Line 74:     * **To generate HTML output of the Impala SQL Reference, run the following command:**
            : 
            :         ```
            :         ./bin/dita -input <path_to_impala_sqlref.ditamap> -format html5 \
            :           -output <path_to_build_output_directory> \
            :           -filter <path_to_impala_html.ditaval>
            :         ```
            : 
            :     * **To generate PDF output of the Impala SQL Reference, run the following command:**
            : 
            :         ```
            :         ./bin/dita -input <path_to_impala_sqlref.ditamap> -format pdf \
            :           -output <path_to_build_output_directory> \
            :           -filter <path_to_impala_pdf.ditaval>
            :         ```
> You'd have to tell me, since you are the initial committer of this file. On
Laurel was the original author. I'll add her to the review.


PS5, Line 111: y
             :    `/Users/<username>/.bash_profile`. Edit
> Done
It will be fine if you open a new terminal. I'd suggest assing "source" to these instructions in step 1 so people who don't open a new terminal will get the right result.


-- 
To view, visit http://gerrit.cloudera.org:8080/6512
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71ae79ecd346045697fe225140ee9a317c5a337f
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-HasComments: Yes