Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 46BAB200C56 for ; Fri, 31 Mar 2017 05:26:57 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 452C5160B98; Fri, 31 Mar 2017 03:26:57 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8A8CE160B8B for ; Fri, 31 Mar 2017 05:26:56 +0200 (CEST) Received: (qmail 51653 invoked by uid 500); 31 Mar 2017 03:26:55 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 51642 invoked by uid 99); 31 Mar 2017 03:26:55 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 31 Mar 2017 03:26:55 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 3017C1A0510 for ; Fri, 31 Mar 2017 03:26:55 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 5BJo-EUvH5nM for ; Fri, 31 Mar 2017 03:26:54 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 4B85C5F20C for ; Fri, 31 Mar 2017 03:26:54 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v2V3QrEq031405; Fri, 31 Mar 2017 03:26:53 GMT Message-Id: <201703310326.v2V3QrEq031405@ip-10-146-233-104.ec2.internal> Date: Fri, 31 Mar 2017 03:26:53 +0000 From: "Impala Public Jenkins (Code Review)" To: Marcel Kornacker , impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: merged Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_Remove_caching_of_llvm_StructType_by_TupleDescriptor=3A=3AGetLlvmStruct=28=29=2E=0A?= X-Gerrit-Change-Id: I6f765048f36b9e596aeb4e4482d38b94f5ffba06 X-Gerrit-ChangeURL: X-Gerrit-Commit: 4c4235f4b23a6050d5a5efe9f358fca719e97c19 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Fri, 31 Mar 2017 03:26:57 -0000 Impala Public Jenkins has submitted this change and it was merged. Change subject: Remove caching of llvm StructType by TupleDescriptor::GetLlvmStruct(). ...................................................................... Remove caching of llvm StructType by TupleDescriptor::GetLlvmStruct(). This caching is causing problems when multiple threads are involved in query startup, which is being implemented as part of the move to a per-query exec rpc (IMPALA-2550). Change-Id: I6f765048f36b9e596aeb4e4482d38b94f5ffba06 Reviewed-on: http://gerrit.cloudera.org:8080/6511 Reviewed-by: Marcel Kornacker Tested-by: Impala Public Jenkins --- M be/src/runtime/descriptors.cc M be/src/runtime/descriptors.h 2 files changed, 40 insertions(+), 46 deletions(-) Approvals: Marcel Kornacker: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/6511 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f765048f36b9e596aeb4e4482d38b94f5ffba06 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Marcel Kornacker Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Tim Armstrong