Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201703300249.v2U2nDhV007751@ip-10-146-233-104.ec2.internal>
Date: Thu, 30 Mar 2017 02:49:12 +0000
From: "Zach Amsden (Code Review)" <gerrit@cloudera.org>
To: Bharath Vissapragada <bharathv@cloudera.com>,
        Henry Robinson <henry@cloudera.com>, impala-cr@cloudera.com,
        reviews@impala.incubator.apache.org
CC: Jim Apple <jbapple-impala@apache.org>, Lars Volker <lv@cloudera.com>
Reply-To: zamsden@cloudera.com
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5123=3A_Fix_ASAN_use_after_free_in_timezone_db=0A?=
In-Reply-To: <gerrit.1490739495000.I490f741403ea2004bc51394aa1251577337b1e1d@gerrit.cloudera.org>
References: <gerrit.1490739495000.I490f741403ea2004bc51394aa1251577337b1e1d@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.7
archived-at: Thu, 30 Mar 2017 02:49:18 -0000

Hello Bharath Vissapragada, Henry Robinson,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/6503

to look at the new patch set (#5).

Change subject: IMPALA-5123: Fix ASAN use after free in timezone_db
......................................................................

IMPALA-5123: Fix ASAN use after free in timezone_db

The issue is that the string temporary returned by .string goes
out of scope immediately after being created.  Also, the API
to mkstemp is unclear on whether it modifies the string in place.
Just strdup() the c_str() to be safe - this is not performance
critical code.

Testing: ASAN build, running expr-test be test; ASAN fails before,
passes after this change.

Change-Id: I490f741403ea2004bc51394aa1251577337b1e1d
---
M be/src/exprs/timezone_db.cc
1 file changed, 10 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/6503/5
-- 
To view, visit http://gerrit.cloudera.org:8080/6503
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I490f741403ea2004bc51394aa1251577337b1e1d
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden <zamsden@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera.com>