Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 424D4200C46 for ; Wed, 29 Mar 2017 21:28:31 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 40B1B160B8A; Wed, 29 Mar 2017 19:28:31 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2B81F160B5D for ; Wed, 29 Mar 2017 21:28:30 +0200 (CEST) Received: (qmail 76689 invoked by uid 500); 29 Mar 2017 19:28:29 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 76674 invoked by uid 99); 29 Mar 2017 19:28:28 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Mar 2017 19:28:28 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 70085C002B for ; Wed, 29 Mar 2017 19:28:28 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 0C07OUnSA8PQ for ; Wed, 29 Mar 2017 19:28:27 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 9B67D5FD89 for ; Wed, 29 Mar 2017 19:28:27 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v2TJSQ7n030532; Wed, 29 Mar 2017 19:28:26 GMT Message-Id: <201703291928.v2TJSQ7n030532@ip-10-146-233-104.ec2.internal> Date: Wed, 29 Mar 2017 19:28:26 +0000 From: "Zach Amsden (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Henry Robinson , Bharath Vissapragada , Jim Apple , Lars Volker Reply-To: zamsden@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5123=3A_Fix_ASAN_use_after_free_in_timezone_db=0A?= X-Gerrit-Change-Id: I490f741403ea2004bc51394aa1251577337b1e1d X-Gerrit-ChangeURL: X-Gerrit-Commit: 53460c566ada560f2da1bb50ecbd0ff307f16f66 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Wed, 29 Mar 2017 19:28:31 -0000 Zach Amsden has posted comments on this change. Change subject: IMPALA-5123: Fix ASAN use after free in timezone_db ...................................................................... Patch Set 4: I'll leave it up to the reviewers to decide which of 3/4 is cleanest. Maybe there is a C++11 drop in replacement for mkstemp that makes all of this footwork unnecessary? Let me look. -- To view, visit http://gerrit.cloudera.org:8080/6503 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I490f741403ea2004bc51394aa1251577337b1e1d Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Zach Amsden Gerrit-HasComments: No