Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201703231859.v2NIx003028631@ip-10-146-233-104.ec2.internal>
Date: Thu, 23 Mar 2017 18:59:00 +0000
From: "Henry Robinson (Code Review)" <gerrit@cloudera.org>
To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org
CC: Matthew Jacobs <mj@cloudera.com>
Reply-To: henry@cloudera.com
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4669=3A_=5BKUTIL=5D_Add_kudu_util_library_to_the_build=2E=0A?=
In-Reply-To: <gerrit.1484350425000.I8da798ee55506d6f969416b17c191eb03cb215f5@gerrit.cloudera.org>
References: <gerrit.1484350425000.I8da798ee55506d6f969416b17c191eb03cb215f5@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.7
archived-at: Thu, 23 Mar 2017 18:59:11 -0000

Henry Robinson has posted comments on this change.

Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build.
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/5715/1/CMakeLists.txt
File CMakeLists.txt:

PS1, Line 294:     
> 2 spaces
Done


http://gerrit.cloudera.org:8080/#/c/5715/1/be/CMakeLists.txt
File be/CMakeLists.txt:

Line 150: # Kudu flags
> please add why these are specified or where they came from
Done


PS1, Line 292: maintenance_manager_proto
> can this be linked in kudu_util so it doesn't have to bleed in here? it's c
Fixed.


http://gerrit.cloudera.org:8080/#/c/5715/1/be/src/kudu/util/CMakeLists.txt
File be/src/kudu/util/CMakeLists.txt:

PS1, Line 185: #  version_info.cc TODO(KRPC): Consider re-adding
> why? remove the stub file if we don't compile it
I think removing the stub would be annoying for future updates to this directory - it would just creep back in.


-- 
To view, visit http://gerrit.cloudera.org:8080/5715
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8da798ee55506d6f969416b17c191eb03cb215f5
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes