Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id DC29F200C4B for ; Mon, 20 Mar 2017 20:32:01 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id DAC9C160B76; Mon, 20 Mar 2017 19:32:01 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0B5F7160B71 for ; Mon, 20 Mar 2017 20:32:00 +0100 (CET) Received: (qmail 56897 invoked by uid 500); 20 Mar 2017 19:32:00 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 56877 invoked by uid 99); 20 Mar 2017 19:32:00 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 Mar 2017 19:32:00 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 94D22C0C24 for ; Mon, 20 Mar 2017 19:31:59 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id DoqPSaYT4wsz for ; Mon, 20 Mar 2017 19:31:58 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 4E1425F649 for ; Mon, 20 Mar 2017 19:31:58 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v2KJVva7002903; Mon, 20 Mar 2017 19:31:57 GMT Message-Id: <201703201931.v2KJVva7002903@ip-10-146-233-104.ec2.internal> Date: Mon, 20 Mar 2017 19:31:57 +0000 From: "Impala Public Jenkins (Code Review)" To: Jim Apple , impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: merged Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5031=3A_Suppress_noisy_UBSAN_errors_from_Thrift=2E=0A?= X-Gerrit-Change-Id: I74ece2157048e8cd24c2536c0a292d9c21f719b9 X-Gerrit-ChangeURL: X-Gerrit-Commit: 58e07530298a33a3b60b2ff13f19068a188a9959 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Mon, 20 Mar 2017 19:32:02 -0000 Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5031: Suppress noisy UBSAN errors from Thrift. ...................................................................... IMPALA-5031: Suppress noisy UBSAN errors from Thrift. This suppresses a Thrift undefined behavior error in which a negative value is left-shifted. See THRIFT-2026 for tracking. One example backtrace from the expr-test backend test: /thrift/protocol/TCompactProtocol.tcc:375:13: runtime error: left shift of negative value -1 #0 0x2b02fe247996 in apache::thrift::protocol::TCompactProtocolT::i64ToZigzag(long) /thrift/protocol/TCompactProtocol.tcc:375:13 #1 0x2b02fe247674 in apache::thrift::protocol::TCompactProtocolT::writeI64(long) /thrift/protocol/TCompactProtocol.tcc:242:24 #2 0x2b02fe239504 in apache::thrift::protocol::TVirtualProtocol, apache::thrift::protocol::TProtocolDefaults>::writeI64_virt(long) /thrift/protocol/TVirtualProtocol.h:409:12 #3 0x2b03014a3a06 in apache::thrift::protocol::TProtocol::writeI64(long) /thrift/protocol/TProtocol.h:453:12 #4 0x2b0301d55c02 in impala::TRuntimeProfileNode::write(apache::thrift::protocol::TProtocol*) const /generated-sources/gen-cpp/RuntimeProfile_types.cpp:827:11 #5 0x2b0301d59e34 in impala::TRuntimeProfileTree::write(apache::thrift::protocol::TProtocol*) const /generated-sources/gen-cpp/RuntimeProfile_types.cpp:1017:15 #6 0x2b02f6f8c7be in impala::Status impala::ThriftSerializer::Serialize(impala::TRuntimeProfileTree*, unsigned int*, unsigned char**) /src/rpc/thrift-util.h:67:7 #7 0x2b02f6f0d23e in impala::Status impala::ThriftSerializer::Serialize(impala::TRuntimeProfileTree*, std::vector >*) /src/rpc/thrift-util.h:54:31 #8 0x2b02f6eec934 in impala::RuntimeProfile::SerializeToArchiveString(std::basic_stringstream, std::allocator >*) const /src/util/runtime-profile.cc:727:19 #9 0x2b02f6eec640 in impala::RuntimeProfile::SerializeToArchiveString() const /src/util/runtime-profile.cc:718:3 #10 0x2b02feda626c in impala::ImpalaServer::ArchiveQuery(impala::ImpalaServer::QueryExecState const&) /src/service/impala-server.cc:671:39 #11 0x2b02fedb57b0 in impala::ImpalaServer::UnregisterQuery(impala::TUniqueId const&, bool, impala::Status const*) /src/service/impala-server.cc:972:3 #12 0x2b02ff15b666 in impala::ImpalaServer::close(beeswax::QueryHandle const&) /src/service/impala-beeswax-server.cc:236:29 #13 0x2b030177dc14 in beeswax::BeeswaxServiceProcessor::process_close(int, apache::thrift::protocol::TProtocol*, apache::thrift::protocol::TProtocol*, void*) /generated-sources/gen-cpp/BeeswaxService.cpp:3543:5 #14 0x2b0301763825 in beeswax::BeeswaxServiceProcessor::dispatchCall(apache::thrift::protocol::TProtocol*, apache::thrift::protocol::TProtocol*, std::string const&, int, void*) /generated-sources/gen-cpp/BeeswaxService.cpp:2952:3 #15 0x2b03016bc2d6 in impala::ImpalaServiceProcessor::dispatchCall(apache::thrift::protocol::TProtocol*, apache::thrift::protocol::TProtocol*, std::string const&, int, void*) /generated-sources/gen-cpp/ImpalaService.cpp:1673:12 #16 0x2b02f650138e in apache::thrift::TDispatchProcessor::process(boost::shared_ptr, boost::shared_ptr, void*) /thrift/TDispatchProcessor.h:121:12 #17 0x1d4080a in apache::thrift::server::TThreadPoolServer::Task::run() (/build/debug/exprs/expr-test+0x1d4080a) #18 0x1d23e38 in apache::thrift::concurrency::ThreadManager::Worker::run() (/build/debug/exprs/expr-test+0x1d23e38) #19 0x2b02fe2be520 in impala::ThriftThread::RunRunnable(boost::shared_ptr, impala::Promise*) /src/rpc/thrift-thread.cc:64:3 #20 0x2b02fe2c4c6b in boost::_mfi::mf2, impala::Promise*>::operator()(impala::ThriftThread*, boost::shared_ptr, impala::Promise*) const /boost/bind/mem_fn_template.hpp:280:16 #21 0x2b02fe2c498a in void boost::_bi::list3, boost::_bi::value >, boost::_bi::value*> >::operator(), impala::Promise*>, boost::_bi::list0>(boost::_bi::type, boost::_mfi::mf2, impala::Promise*>&, boost::_bi::list0&, int) /boost/bind/bind.hpp:392:9 #22 0x2b02fe2c444b in boost::_bi::bind_t, impala::Promise*>, boost::_bi::list3, boost::_bi::value >, boost::_bi::value*> > >::operator()() /boost/bind/bind_template.hpp:20:16 #23 0x2b02fe2c3709 in boost::detail::function::void_function_obj_invoker0, impala::Promise*>, boost::_bi::list3, boost::_bi::value >, boost::_bi::value*> > >, void>::invoke(boost::detail::function::function_buffer&) /boost/function/function_template.hpp:153:11 #24 0x2b02f70085d4 in boost::function0::operator()() const /boost/function/function_template.hpp:766:14 #25 0x2b02f6ff9710 in impala::Thread::SuperviseThread(std::string const&, std::string const&, boost::function, impala::Promise*) /src/util/thread.cc:325:3 #26 0x2b02f7021783 in void boost::_bi::list4, boost::_bi::value, boost::_bi::value >, boost::_bi::value*> >::operator(), impala::Promise*), boost::_bi::list0>(boost::_bi::type, void (*&)(std::string const&, std::string const&, boost::function, impala::Promise*), boost::_bi::list0&, int) /boost/bind/bind.hpp:457:9 #27 0x2b02f70210ab in boost::_bi::bind_t, impala::Promise*), boost::_bi::list4, boost::_bi::value, boost::_bi::value >, boost::_bi::value*> > >::operator()() /boost/bind/bind_template.hpp:20:16 #28 0x2b02f701faf5 in boost::detail::thread_data, impala::Promise*), boost::_bi::list4, boost::_bi::value, boost::_bi::value >, boost::_bi::value*> > > >::run() /boost/thread/detail/thread.hpp:116:17 #29 0xfaa189 in thread_proxy (/build/debug/exprs/expr-test+0xfaa189) #30 0x2b0305c5e183 in start_thread (/lib/x86_64-linux-gnu/libpthread.so.0+0x8183) #31 0x2b0305f6e37c in clone (/lib/x86_64-linux-gnu/libc.so.6+0xfa37c) Change-Id: I74ece2157048e8cd24c2536c0a292d9c21f719b9 Reviewed-on: http://gerrit.cloudera.org:8080/6425 Reviewed-by: Tim Armstrong Tested-by: Impala Public Jenkins --- M bin/ubsan-suppressions.txt 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Impala Public Jenkins: Verified Tim Armstrong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/6425 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74ece2157048e8cd24c2536c0a292d9c21f719b9 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong