Return-Path: <reviews-return-10533-archive-asf-public=cust-asf.ponee.io@impala.incubator.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 7D86B200C4B
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Mon, 20 Mar 2017 16:44:09 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id 7C3EF160B81; Mon, 20 Mar 2017 15:44:09 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id C2B52160B76
	for <archive-asf-public@cust-asf.ponee.io>; Mon, 20 Mar 2017 16:44:08 +0100 (CET)
Received: (qmail 17606 invoked by uid 500); 20 Mar 2017 15:44:08 -0000
Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:reviews-help@impala.incubator.apache.org>
List-Unsubscribe: <mailto:reviews-unsubscribe@impala.incubator.apache.org>
List-Post: <mailto:reviews@impala.incubator.apache.org>
List-Id: <reviews.impala.incubator.apache.org>
Delivered-To: mailing list reviews@impala.incubator.apache.org
Received: (qmail 17593 invoked by uid 99); 20 Mar 2017 15:44:07 -0000
Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 Mar 2017 15:44:07 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 523F6CD276
	for <reviews@impala.apache.org>; Mon, 20 Mar 2017 15:44:07 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: 0.362
X-Spam-Level: 
X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31
	tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled
Received: from mx1-lw-us.apache.org ([10.40.0.8])
	by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024)
	with ESMTP id mGN_jmYoxBPj for <reviews@impala.apache.org>;
	Mon, 20 Mar 2017 15:44:06 +0000 (UTC)
Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251])
	by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id B2B1C5F238
	for <reviews@impala.incubator.apache.org>; Mon, 20 Mar 2017 15:44:06 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v2KFi0O4031219;
	Mon, 20 Mar 2017 15:44:00 GMT
Message-Id: <201703201544.v2KFi0O4031219@ip-10-146-233-104.ec2.internal>
Date: Mon, 20 Mar 2017 15:44:00 +0000
From: "Tim Armstrong (Code Review)" <gerrit@cloudera.org>
To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org
CC: Dan Hecht <dhecht@cloudera.com>, Jim Apple <jbapple-impala@apache.org>
Reply-To: tarmstrong@cloudera.com
X-Gerrit-MessageType: comment
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-3203=3A_Part_1=3A_Free_list_implementation=0A?=
X-Gerrit-Change-Id: Ia89acfa4efdecb96d3678443b4748932b4133b9b
X-Gerrit-ChangeURL: <http://gerrit.cloudera.org:8080/6410>
X-Gerrit-Commit: e8990d2ebeae6220301fb108f52f42f0cbe37c15
In-Reply-To: <gerrit.1489625207000.Ia89acfa4efdecb96d3678443b4748932b4133b9b@gerrit.cloudera.org>
References: <gerrit.1489625207000.Ia89acfa4efdecb96d3678443b4748932b4133b9b@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.7
archived-at: Mon, 20 Mar 2017 15:44:09 -0000

Tim Armstrong has posted comments on this change.

Change subject: IMPALA-3203: Part 1: Free list implementation
......................................................................


Patch Set 7:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/6410/6/be/src/runtime/bufferpool/free-list-test.cc
File be/src/runtime/bufferpool/free-list-test.cc:

Line 112:       vector<const void*> addrs = GetSortedAddrs(buffers);
> can also be a const vector
Done


http://gerrit.cloudera.org:8080/#/c/6410/6/be/src/runtime/bufferpool/free-list.h
File be/src/runtime/bufferpool/free-list.h:

Line 117:     return SortCompare(b2, b1);
> You might want to leave a note on FreeBuffers that its complexity is Theta(
Done. In the caller I'm going to always remove a fixed percentage of the entries p when the list gets full, so overall it should be amortised log n time, since FreeBuffers() will be called only ones every (p * n) operations.


http://gerrit.cloudera.org:8080/#/c/6410/7/be/src/runtime/bufferpool/free-list.h
File be/src/runtime/bufferpool/free-list.h:

PS7, Line 51: over
> "into"
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/6410
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia89acfa4efdecb96d3678443b4748932b4133b9b
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes