Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 44814200C3A for ; Fri, 17 Mar 2017 07:09:31 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 43123160B8B; Fri, 17 Mar 2017 06:09:31 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8DF5A160B78 for ; Fri, 17 Mar 2017 07:09:30 +0100 (CET) Received: (qmail 28487 invoked by uid 500); 17 Mar 2017 06:09:29 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 28475 invoked by uid 99); 17 Mar 2017 06:09:29 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Mar 2017 06:09:29 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id EE84F1A077A for ; Fri, 17 Mar 2017 06:09:28 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id WA4t-jUes3uG for ; Fri, 17 Mar 2017 06:09:28 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 126265F56B for ; Fri, 17 Mar 2017 06:09:28 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v2H69Pmf003028; Fri, 17 Mar 2017 06:09:25 GMT Message-Id: <201703170609.v2H69Pmf003028@ip-10-146-233-104.ec2.internal> Date: Fri, 17 Mar 2017 06:09:25 +0000 From: "Sailesh Mukil (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Henry Robinson Reply-To: sailesh@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5041=3A_Allow_AuthManager=3A=3AInit=28=29_to_be_called_more_than_once=0A?= X-Gerrit-Change-Id: I12cc210aa422f077446ea728ebf76921351417b0 X-Gerrit-ChangeURL: X-Gerrit-Commit: 2ae2f5ce1109629acb204a3cae35561d388c8c29 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Fri, 17 Mar 2017 06:09:31 -0000 Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5041: Allow AuthManager::Init() to be called more than once ...................................................................... Patch Set 3: Code-Review+2 (3 comments) Thanks for the review! Carry +2. http://gerrit.cloudera.org:8080/#/c/6333/2//COMMIT_MSG Commit Message: PS2, Line 7: Allow AuthManager::Init() to be called more than once > Nit picking further: "Allow AuthManager::Init() to be called more than once Done http://gerrit.cloudera.org:8080/#/c/6333/2/be/src/rpc/authentication.h File be/src/rpc/authentication.h: PS2, Line 42: instant > objects don't run, they have lifetime. So maybe "AuthManager should be trea Done PS2, Line 43: more than onc > more than once Done -- To view, visit http://gerrit.cloudera.org:8080/6333 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12cc210aa422f077446ea728ebf76921351417b0 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Sailesh Mukil Gerrit-HasComments: Yes