Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D39E1200C3A for ; Fri, 17 Mar 2017 00:46:40 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id D22AF160B8B; Thu, 16 Mar 2017 23:46:40 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 286EE160B78 for ; Fri, 17 Mar 2017 00:46:40 +0100 (CET) Received: (qmail 91885 invoked by uid 500); 16 Mar 2017 23:46:39 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 91869 invoked by uid 99); 16 Mar 2017 23:46:39 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Mar 2017 23:46:39 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id B1473C3ABC for ; Thu, 16 Mar 2017 23:46:38 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id iWmQWwC0lJW9 for ; Thu, 16 Mar 2017 23:46:36 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 00B495FBE4 for ; Thu, 16 Mar 2017 23:46:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v2GNkYou028462; Thu, 16 Mar 2017 23:46:34 GMT Message-Id: <201703162346.v2GNkYou028462@ip-10-146-233-104.ec2.internal> Date: Thu, 16 Mar 2017 23:46:34 +0000 From: "Tim Armstrong (Code Review)" To: Henry Robinson , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Matthew Jacobs Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5Bnative-toolchain-CR=5D_IMPALA-5057=3A_Upgrade_gflags_=282=2E2=2E0=29_and_glog_=280=2E3=2E4-p2=29=0A?= X-Gerrit-Change-Id: I43bfe51a7b85f55f75e0bfe9f4eda1eea7856ff5 X-Gerrit-ChangeURL: X-Gerrit-Commit: 2e58fe863b07829892c06a8a9a3b7558d9dbb619 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Thu, 16 Mar 2017 23:46:41 -0000 Tim Armstrong has posted comments on this change. Change subject: IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2) ...................................................................... Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/6372/3/source/gflags/build.sh File source/gflags/build.sh: Line 40: CFLAGS="-fPIC -DPIC" wrap make -j${BUILD_THREADS:-4} install The CFLAGS needs some explanation - this is to force CMake to build static libraries with PIC? It would be nice to do it in a more direct way but googling indicates there may not be a nice way to achieve this. -- To view, visit http://gerrit.cloudera.org:8080/6372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43bfe51a7b85f55f75e0bfe9f4eda1eea7856ff5 Gerrit-PatchSet: 3 Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes