Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 29777200C3D for ; Tue, 14 Mar 2017 19:01:16 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 27EE5160B7E; Tue, 14 Mar 2017 18:01:16 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 71360160B63 for ; Tue, 14 Mar 2017 19:01:15 +0100 (CET) Received: (qmail 77347 invoked by uid 500); 14 Mar 2017 18:01:14 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 77336 invoked by uid 99); 14 Mar 2017 18:01:14 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Mar 2017 18:01:14 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id D6537C132E for ; Tue, 14 Mar 2017 18:01:13 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id avXvpj_UhnXS for ; Tue, 14 Mar 2017 18:01:13 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 0C0EB5FB6B for ; Tue, 14 Mar 2017 18:01:13 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v2EI15lG008585; Tue, 14 Mar 2017 18:01:05 GMT Message-Id: <201703141801.v2EI15lG008585@ip-10-146-233-104.ec2.internal> Date: Tue, 14 Mar 2017 18:01:05 +0000 From: "Michael Ho (Code Review)" To: Matthew Jacobs , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: kwho@cloudera.com X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_Remove_key-normalizer*=2Eh_which_appear_to_be_dead_code_at_this_point=2E=0A?= X-Gerrit-Change-Id: If890c2a2589148db38ea333a518dc1368dcd5459 X-Gerrit-ChangeURL: X-Gerrit-Commit: 966adb80dd455167945042dbde16fa2e4d3f6ed7 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Tue, 14 Mar 2017 18:01:16 -0000 Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6377 to look at the new patch set (#2). Change subject: Remove key-normalizer*.h which appear to be dead code at this point. ...................................................................... Remove key-normalizer*.h which appear to be dead code at this point. Testing done: compiled Impala. Change-Id: If890c2a2589148db38ea333a518dc1368dcd5459 --- D be/src/util/key-normalizer.h D be/src/util/key-normalizer.inline.h 2 files changed, 0 insertions(+), 299 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/6377/2 -- To view, visit http://gerrit.cloudera.org:8080/6377 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: If890c2a2589148db38ea333a518dc1368dcd5459 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho Gerrit-Reviewer: Matthew Jacobs