Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 8AC34200C45 for ; Tue, 14 Mar 2017 02:39:04 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 89482160B5D; Tue, 14 Mar 2017 01:39:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D6C22160B85 for ; Tue, 14 Mar 2017 02:39:03 +0100 (CET) Received: (qmail 54413 invoked by uid 500); 14 Mar 2017 01:39:03 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 54402 invoked by uid 99); 14 Mar 2017 01:39:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Mar 2017 01:39:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 788221819E4 for ; Tue, 14 Mar 2017 01:39:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 9md-IDDEm4tu for ; Tue, 14 Mar 2017 01:39:01 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 85ED75F295 for ; Tue, 14 Mar 2017 01:39:01 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v2E1d0MQ026756; Tue, 14 Mar 2017 01:39:00 GMT Message-Id: <201703140139.v2E1d0MQ026756@ip-10-146-233-104.ec2.internal> Date: Tue, 14 Mar 2017 01:39:00 +0000 From: "Impala Public Jenkins (Code Review)" To: Zach Amsden , impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: merged Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4762=3A_RECOVER_PARTITIONS_should_batch_partition_updates=0A?= X-Gerrit-Change-Id: I7f9334051b11ba8fa16159b7ca67ddc7f2392733 X-Gerrit-ChangeURL: X-Gerrit-Commit: eec8d6fd15dc9e914a773aab1390f95d97f515ae In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Tue, 14 Mar 2017 01:39:04 -0000 Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4762: RECOVER PARTITIONS should batch partition updates ...................................................................... IMPALA-4762: RECOVER PARTITIONS should batch partition updates Batch updates when doing a RECOVER PARTITIONS on over 500 partitions at a time to avoid HMS timeouts, possible OOM. Testing: Expanded test coverage with a new python test for this case. Test takes ~18s to run. Change-Id: I7f9334051b11ba8fa16159b7ca67ddc7f2392733 Reviewed-on: http://gerrit.cloudera.org:8080/6275 Reviewed-by: Dimitris Tsirogiannis Tested-by: Impala Public Jenkins --- M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java M tests/metadata/test_recover_partitions.py 2 files changed, 59 insertions(+), 26 deletions(-) Approvals: Impala Public Jenkins: Verified Dimitris Tsirogiannis: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/6275 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7f9334051b11ba8fa16159b7ca67ddc7f2392733 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zach Amsden