Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 16E8B200C28 for ; Mon, 13 Mar 2017 23:50:16 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 157F0160B5D; Mon, 13 Mar 2017 22:50:16 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5BA3C160B6C for ; Mon, 13 Mar 2017 23:50:15 +0100 (CET) Received: (qmail 20318 invoked by uid 500); 13 Mar 2017 22:50:14 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 20154 invoked by uid 99); 13 Mar 2017 22:50:14 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Mar 2017 22:50:14 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id B485C182765 for ; Mon, 13 Mar 2017 22:50:13 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Mz4wCobZXOBm for ; Mon, 13 Mar 2017 22:50:09 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id EE3BC5F252 for ; Mon, 13 Mar 2017 22:50:08 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v2DMo7ZX022305; Mon, 13 Mar 2017 22:50:07 GMT Message-Id: <201703132250.v2DMo7ZX022305@ip-10-146-233-104.ec2.internal> Date: Mon, 13 Mar 2017 22:50:07 +0000 From: "Matthew Jacobs (Code Review)" To: Henry Robinson , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: mj@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5Bnative-toolchain-CR=5D_IMPALA-5057=3A_Upgrade_gflags_=282=2E2=2E0=29_and_glog_=280=2E3=2E4-p2=29=0A?= X-Gerrit-Change-Id: I43bfe51a7b85f55f75e0bfe9f4eda1eea7856ff5 X-Gerrit-ChangeURL: X-Gerrit-Commit: 928762b0442fb55e1444d2ed60d9b47cf771a769 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Mon, 13 Mar 2017 22:50:16 -0000 Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2) ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/6372/2/source/gflags/build.sh File source/gflags/build.sh: PS2, Line 33: if [ -e CMakeLists.txt ]; then : wrap cmake -DBUILD_STATIC_LIBS=ON -DCMAKE_INSTALL_PREFIX=$LOCAL_INSTALL -DCMAKE_BUILD_TYPE=RELEASE : else : wrap ./configure --with-pic --prefix=$LOCAL_INSTALL I assume the CMakeLists.txt path is for the newer version? I think it'd be cleaner to check the PACKAGE_VERSION. If that's too hard, please leave comments so future readers have more context. http://gerrit.cloudera.org:8080/#/c/6372/2/source/glog/glog-0.3.4-patches/0001-Allow-glog-to-accept-a-message-listener.patch File source/glog/glog-0.3.4-patches/0001-Allow-glog-to-accept-a-message-listener.patch: Is this patch from a source you can reference, or is this new code that needs to be reviewed more carefully? http://gerrit.cloudera.org:8080/#/c/6372/2/source/glog/glog-0.3.4-patches/0002-Preserve-custom-signal-handler-for-dcheck.patch File source/glog/glog-0.3.4-patches/0002-Preserve-custom-signal-handler-for-dcheck.patch: Line 1: From ba317a0a34e6b0d475dc11b9e9ad4a044fed1b70 Mon Sep 17 00:00:00 2001 same as previous patch -- To view, visit http://gerrit.cloudera.org:8080/6372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43bfe51a7b85f55f75e0bfe9f4eda1eea7856ff5 Gerrit-PatchSet: 2 Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Matthew Jacobs Gerrit-HasComments: Yes