Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B8DA6200C36 for ; Fri, 10 Mar 2017 22:05:19 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id B78F0160B79; Fri, 10 Mar 2017 21:05:19 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 115E5160B67 for ; Fri, 10 Mar 2017 22:05:18 +0100 (CET) Received: (qmail 5768 invoked by uid 500); 10 Mar 2017 21:05:18 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 5754 invoked by uid 99); 10 Mar 2017 21:05:18 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 Mar 2017 21:05:18 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id A2F79C20F6 for ; Fri, 10 Mar 2017 21:05:17 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id f-Uj720ryY0i for ; Fri, 10 Mar 2017 21:05:17 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 698875F1EE for ; Fri, 10 Mar 2017 21:05:16 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v2AL5Evh016394; Fri, 10 Mar 2017 21:05:14 GMT Message-Id: <201703102105.v2AL5Evh016394@ip-10-146-233-104.ec2.internal> Date: Fri, 10 Mar 2017 21:05:14 +0000 From: "Joe McDonnell (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Marcel Kornacker , Lars Volker , Tim Armstrong Reply-To: joemcdonnell@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5055=3A_Fix_DCHECK_in_parquet-column-readers=2Ecc_ReadPageHeader=28=29=0A?= X-Gerrit-Change-Id: Ie22a8cf6b53f507c378c2efe302482409935184e X-Gerrit-ChangeURL: X-Gerrit-Commit: c87034562320852ed7ba914f02d7627c60661416 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Fri, 10 Mar 2017 21:05:19 -0000 Joe McDonnell has posted comments on this change. Change subject: IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader() ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6328/1//COMMIT_MSG Commit Message: Line 9: GetBytes only sets status in the case of an error. This means that > long lines Done Line 13: I verified that the other uses of status are ok. Most do not check > I think we should change GetBytes() to always initialize status. The functi Since this JIRA is a build blocker, I am reluctant to delay it to do performance tests. I filed IMPALA-5060 to track that change. -- To view, visit http://gerrit.cloudera.org:8080/6328 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie22a8cf6b53f507c378c2efe302482409935184e Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes