Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D7A36200C41 for ; Fri, 10 Mar 2017 06:42:50 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id D637A160B84; Fri, 10 Mar 2017 05:42:50 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2D00F160B75 for ; Fri, 10 Mar 2017 06:42:50 +0100 (CET) Received: (qmail 27751 invoked by uid 500); 10 Mar 2017 05:42:49 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 27736 invoked by uid 99); 10 Mar 2017 05:42:48 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 Mar 2017 05:42:48 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 377AD186147 for ; Fri, 10 Mar 2017 05:42:48 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id TcCTA511mQCN for ; Fri, 10 Mar 2017 05:42:47 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id D58095F39F for ; Fri, 10 Mar 2017 05:42:46 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v2A5gjdD007970; Fri, 10 Mar 2017 05:42:45 GMT Message-Id: <201703100542.v2A5gjdD007970@ip-10-146-233-104.ec2.internal> Date: Fri, 10 Mar 2017 05:42:45 +0000 From: "Tim Armstrong (Code Review)" To: Michael Ho , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4008=3A_Don=27t_bake_fields_into_generated_IR_functions_of_OldHashTable=0A?= X-Gerrit-Change-Id: I75500827dff56b1fa9e5296e8e8d8667ab54aef8 X-Gerrit-ChangeURL: X-Gerrit-Commit: b218d2c548f142abc878d18c32bb104a492dd13c In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Fri, 10 Mar 2017 05:42:51 -0000 Tim Armstrong has posted comments on this change. Change subject: IMPALA-4008: Don't bake fields into generated IR functions of OldHashTable ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6263/1//COMMIT_MSG Commit Message: Line 16: > I looked at that instance at ScalarFnCall(). It t should be fine for MT as I looked and it seemed like the fallback would never be used since the GetCodegendComputeFn() should never return OK + NULL. Not a big deal anyway. -- To view, visit http://gerrit.cloudera.org:8080/6263 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75500827dff56b1fa9e5296e8e8d8667ab54aef8 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes