Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 99977200C41 for ; Fri, 10 Mar 2017 03:11:32 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 97F0B160B84; Fri, 10 Mar 2017 02:11:32 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E2B47160B75 for ; Fri, 10 Mar 2017 03:11:31 +0100 (CET) Received: (qmail 59193 invoked by uid 500); 10 Mar 2017 02:11:31 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 59182 invoked by uid 99); 10 Mar 2017 02:11:30 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 Mar 2017 02:11:30 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 75B47C0468 for ; Fri, 10 Mar 2017 02:11:30 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id l14FhTgR6brS for ; Fri, 10 Mar 2017 02:11:29 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id AD8725F1EE for ; Fri, 10 Mar 2017 02:11:29 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v2A2BPFK004416; Fri, 10 Mar 2017 02:11:25 GMT Message-Id: <201703100211.v2A2BPFK004416@ip-10-146-233-104.ec2.internal> Date: Fri, 10 Mar 2017 02:11:25 +0000 From: "Alex Behm (Code Review)" To: Joe McDonnell , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: alex.behm@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5039=3A_Fix_variability_in_parquet_dictionary_filtering_test=0A?= X-Gerrit-Change-Id: I6b7b84d973b3ac678a24e82900f2637d569158bb X-Gerrit-ChangeURL: X-Gerrit-Commit: cf18ca6de6c3b68e159d6a5d90138ec75763b76b In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Fri, 10 Mar 2017 02:11:32 -0000 Alex Behm has posted comments on this change. Change subject: IMPALA-5039: Fix variability in parquet dictionary filtering test ...................................................................... Patch Set 3: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/6301/2/tests/common/test_result_verifier.py File tests/common/test_result_verifier.py: Line 537: for expected_line in expected_lines: > You can think of each of these as sparse lists of mutually exclusive things Thanks, make sense. Works for me. http://gerrit.cloudera.org:8080/#/c/6301/3/tests/common/test_result_verifier.py File tests/common/test_result_verifier.py: Line 571: (function, field, expected_value, actual_value)) I think we should dump the complete actual profile as well for better debugging. -- To view, visit http://gerrit.cloudera.org:8080/6301 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b7b84d973b3ac678a24e82900f2637d569158bb Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Joe McDonnell Gerrit-HasComments: Yes