Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201703092216.v29MG5ht024873@ip-10-146-233-104.ec2.internal>
Date: Thu, 9 Mar 2017 22:16:05 +0000
From: "Alex Behm (Code Review)" <gerrit@cloudera.org>
To: Taras Bobrovytsky <tbobrovytsky@cloudera.com>, impala-cr@cloudera.com,
        reviews@impala.incubator.apache.org
CC: Tim Armstrong <tarmstrong@cloudera.com>,
        Marcel Kornacker <marcel@cloudera.com>,
        Dan Hecht <dhecht@cloudera.com>
Reply-To: alex.behm@cloudera.com
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-3586=3A_Implement_union_passthrough=0A?=
In-Reply-To: <gerrit.1485560049000.Ia8f6d5062724ba5b78174c3227a7a796d10d8416@gerrit.cloudera.org>
References: <gerrit.1485560049000.Ia8f6d5062724ba5b78174c3227a7a796d10d8416@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.7
archived-at: Thu, 09 Mar 2017 22:16:15 -0000

Alex Behm has posted comments on this change.

Change subject: IMPALA-3586: Implement union passthrough
......................................................................


Patch Set 13:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/5816/13/be/src/exec/union-node.cc
File be/src/exec/union-node.cc:

Line 156:         // It is OK to close the child here because all RowBatches have already been
... because all tuple data has been copied, and we will not be calling ...


Line 174:     child_batch_.reset();
move this before ++child_idx_ to have them clustered?


http://gerrit.cloudera.org:8080/#/c/5816/13/be/src/exec/union-node.h
File be/src/exec/union-node.h:

Line 67:   /// Children that can be passed through, without evaluating and materializing their
single line


Line 109:   inline bool AtEos(int per_fragment_instance_idx) const {
Maybe it's clearer to make GetNextPassThrough() not set eos, and instead have all the *eos setting be done directly inside GetNext(). That way each place different place can do the appropriate checks.


Line 119:     DCHECK_LE(child_idx_, children_.size());
Checking of the child_idx_ is dependent on the aller pattern of advancing the child_idx_ and calling into this AtEos(), another argument for maybe inlining the checks into GetNext() to make this subtle point less disconnected.


-- 
To view, visit http://gerrit.cloudera.org:8080/5816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8f6d5062724ba5b78174c3227a7a796d10d8416
Gerrit-PatchSet: 13
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes