Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9270C200C32 for ; Thu, 9 Mar 2017 08:58:09 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 90DF4160B67; Thu, 9 Mar 2017 07:58:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DBF91160B64 for ; Thu, 9 Mar 2017 08:58:08 +0100 (CET) Received: (qmail 94462 invoked by uid 500); 9 Mar 2017 07:58:08 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 94451 invoked by uid 99); 9 Mar 2017 07:58:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Mar 2017 07:58:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 75A591803A3 for ; Thu, 9 Mar 2017 07:58:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id iNg9EpYHgtNB for ; Thu, 9 Mar 2017 07:58:06 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 258F35F39F for ; Thu, 9 Mar 2017 07:58:06 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v297w4d6009483; Thu, 9 Mar 2017 07:58:04 GMT Message-Id: <201703090758.v297w4d6009483@ip-10-146-233-104.ec2.internal> Date: Thu, 9 Mar 2017 07:58:04 +0000 From: "Taras Bobrovytsky (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Tim Armstrong , Marcel Kornacker , Alex Behm , Dan Hecht Reply-To: tbobrovytsky@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-3586=3A_Implement_union_passthrough=0A?= X-Gerrit-Change-Id: Ia8f6d5062724ba5b78174c3227a7a796d10d8416 X-Gerrit-ChangeURL: X-Gerrit-Commit: 84cd5ab9c00ac02a897ea579317aa9100f99ce1e In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Thu, 09 Mar 2017 07:58:09 -0000 Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3586: Implement union passthrough ...................................................................... Patch Set 12: As Dan pointed out, we don't set eos in the passthrough case, which is a little weird because there will be an unnecessary call to getnext() at the end which will return 0 rows. I fixed this issue in patch 12. -- To view, visit http://gerrit.cloudera.org:8080/5816 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8f6d5062724ba5b78174c3227a7a796d10d8416 Gerrit-PatchSet: 12 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No