Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3457F200C40 for ; Thu, 9 Mar 2017 03:19:41 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 2ED0E160B86; Thu, 9 Mar 2017 02:19:41 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 773C3160B83 for ; Thu, 9 Mar 2017 03:19:40 +0100 (CET) Received: (qmail 54625 invoked by uid 500); 9 Mar 2017 02:19:39 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 54614 invoked by uid 99); 9 Mar 2017 02:19:39 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Mar 2017 02:19:39 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 19FB7188004 for ; Thu, 9 Mar 2017 02:19:39 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id DsuzosuuEMCU for ; Thu, 9 Mar 2017 02:19:36 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 46A785F1EE for ; Thu, 9 Mar 2017 02:19:36 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v292JYJ4004787; Thu, 9 Mar 2017 02:19:34 GMT Message-Id: <201703090219.v292JYJ4004787@ip-10-146-233-104.ec2.internal> Date: Thu, 9 Mar 2017 02:19:34 +0000 From: "Lars Volker (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Alex Behm Reply-To: lv@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4615=3A_Fix_create_table=2Esql_command_order=0A?= X-Gerrit-Change-Id: I0f68eeb75ba2f43b96b8f3d82f902e291d3bd396 X-Gerrit-ChangeURL: X-Gerrit-Commit: a6383665c12822d045e828a439e265f44712a6a0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Thu, 09 Mar 2017 02:19:41 -0000 Lars Volker has posted comments on this change. Change subject: IMPALA-4615: Fix create_table.sql command order ...................................................................... Patch Set 4: Code-Review+2 I figured out that the submit tests failed since I was lacking a final MSCK command. I fixed that, did more manual testing, updated the commit message with my findings, and rebase. Carrying Alex's +2. -- To view, visit http://gerrit.cloudera.org:8080/6317 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f68eeb75ba2f43b96b8f3d82f902e291d3bd396 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-HasComments: No