Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D0D3F200C31 for ; Wed, 8 Mar 2017 19:38:05 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id CF79B160B83; Wed, 8 Mar 2017 18:38:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 272A3160B73 for ; Wed, 8 Mar 2017 19:38:05 +0100 (CET) Received: (qmail 28339 invoked by uid 500); 8 Mar 2017 18:38:04 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 28328 invoked by uid 99); 8 Mar 2017 18:38:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Mar 2017 18:38:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id ADD6DC3ACE for ; Wed, 8 Mar 2017 18:38:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id R-GH79WOc5oD for ; Wed, 8 Mar 2017 18:38:03 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id AF2035F64B for ; Wed, 8 Mar 2017 18:38:02 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v28Ic1tc017009; Wed, 8 Mar 2017 18:38:01 GMT Message-Id: <201703081838.v28Ic1tc017009@ip-10-146-233-104.ec2.internal> Date: Wed, 8 Mar 2017 18:38:01 +0000 From: "Tim Armstrong (Code Review)" To: Michael Ho , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4957=3A_Don=27t_crash_Impalad_on_LLVM_fatal_error=0A?= X-Gerrit-Change-Id: I54706e261ed223eadde347b1184fb0102e03a3d6 X-Gerrit-ChangeURL: X-Gerrit-Commit: cc432b860593bbda28ecc212194c91dbd794050a In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Wed, 08 Mar 2017 18:38:06 -0000 Tim Armstrong has posted comments on this change. Change subject: IMPALA-4957: Don't crash Impalad on LLVM fatal error ...................................................................... Patch Set 2: (1 comment) Were you able to reproduce the problem? Would be good to have some tests since it seems like this would be easy to regress. http://gerrit.cloudera.org:8080/#/c/6318/2/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: PS2, Line 110: [[noreturn]] Is noreturn valid for functions that throw?? -- To view, visit http://gerrit.cloudera.org:8080/6318 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54706e261ed223eadde347b1184fb0102e03a3d6 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes