Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id CE841200C3F for ; Wed, 8 Mar 2017 02:07:34 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id CD033160B74; Wed, 8 Mar 2017 01:07:34 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 23CE9160B68 for ; Wed, 8 Mar 2017 02:07:33 +0100 (CET) Received: (qmail 89887 invoked by uid 500); 8 Mar 2017 01:07:33 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 89876 invoked by uid 99); 8 Mar 2017 01:07:33 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Mar 2017 01:07:33 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id B8E721809F9 for ; Wed, 8 Mar 2017 01:07:32 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id xzPRWavmt9mH for ; Wed, 8 Mar 2017 01:07:32 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 571215F1EE for ; Wed, 8 Mar 2017 01:07:31 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v2817SVa003739; Wed, 8 Mar 2017 01:07:28 GMT Message-Id: <201703080107.v2817SVa003739@ip-10-146-233-104.ec2.internal> Date: Wed, 8 Mar 2017 01:07:28 +0000 From: "Impala Public Jenkins (Code Review)" To: Joe McDonnell , impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: merged Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5038=3A_Fix_file_size_regex_to_include_bytes=0A?= X-Gerrit-Change-Id: I5f7b8480065a4da63c8abaf53aae8aef772f0172 X-Gerrit-ChangeURL: X-Gerrit-Commit: c4fb67c98c44c28f0c375b11a5ef996a2c52bbb2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Wed, 08 Mar 2017 01:07:35 -0000 Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5038: Fix file size regex to include bytes ...................................................................... IMPALA-5038: Fix file size regex to include bytes There is a regex to remove file sizes from test logs to avoid diffs caused by changes in file headers, etc. The regex was detecting size=number correctly, but it does not include the byte unit (i.e. size=900B is distinct from size=900KB). A file size change introduced by IMPALA-4624 caused a diff because the file size changed from 900B to 1.1KB. This fixes the regex to include the byte unit, so that changes of this form do not cause diffs. Change-Id: I5f7b8480065a4da63c8abaf53aae8aef772f0172 Reviewed-on: http://gerrit.cloudera.org:8080/6288 Reviewed-by: Marcel Kornacker Tested-by: Impala Public Jenkins --- M fe/src/test/java/org/apache/impala/testutil/TestUtils.java 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Marcel Kornacker: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/6288 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f7b8480065a4da63c8abaf53aae8aef772f0172 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Marcel Kornacker