Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E7214200C2F for ; Mon, 6 Mar 2017 18:26:14 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id E254C160B76; Mon, 6 Mar 2017 17:26:14 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 396CB160B66 for ; Mon, 6 Mar 2017 18:26:14 +0100 (CET) Received: (qmail 43673 invoked by uid 500); 6 Mar 2017 17:26:13 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 43661 invoked by uid 99); 6 Mar 2017 17:26:13 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Mar 2017 17:26:13 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id D2A71C193A for ; Mon, 6 Mar 2017 17:26:12 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 6eTjJazk2aEc for ; Mon, 6 Mar 2017 17:26:09 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 2103D60DC0 for ; Mon, 6 Mar 2017 17:26:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v26HQ3Vs017019; Mon, 6 Mar 2017 17:26:04 GMT Message-Id: <201703061726.v26HQ3Vs017019@ip-10-146-233-104.ec2.internal> Date: Mon, 6 Mar 2017 17:26:03 +0000 From: "Bharath Vissapragada (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Henry Robinson Reply-To: bharathv@cloudera.com X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_Fix_a_potential_crash_in_Frontend_=26_Catalog_JNI_startup=0A?= X-Gerrit-Change-Id: I35398a8efdb6fdbf7932a32489b2ad8d99b6d76f X-Gerrit-ChangeURL: X-Gerrit-Commit: d77878288dcb29ffe78ec901087b04104e143856 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Mon, 06 Mar 2017 17:26:15 -0000 Bharath Vissapragada has uploaded a new patch set (#2). Change subject: Fix a potential crash in Frontend & Catalog JNI startup ...................................................................... Fix a potential crash in Frontend & Catalog JNI startup Bug: In the startup of the Frotend and the Catalog JVMs, we incorrectly use a local reference that can potentially be GC'ed by the JVM. Any usage of that reference can result in an undefined behavior or a JVM crash. Fix: Move the reference to a global state and eventually free it after the startup. Testing: We can reliably reproduce this crash with the dynamic log levels patch [1] in the following backend tests which start multiple Frontend instances in parallel. - buffered-block-mgr-test - buffered-tuple-stream-test - buffer-pool-test With this patch, all the above tests pass. [1] https://gerrit.cloudera.org/#/c/5792/ Change-Id: I35398a8efdb6fdbf7932a32489b2ad8d99b6d76f --- M be/src/catalog/catalog.cc M be/src/service/frontend.cc M be/src/util/backend-gflag-util.cc 3 files changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/6264/2 -- To view, visit http://gerrit.cloudera.org:8080/6264 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I35398a8efdb6fdbf7932a32489b2ad8d99b6d76f Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Henry Robinson