Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3F516200C3B for ; Sat, 4 Mar 2017 02:05:34 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 3DE27160B80; Sat, 4 Mar 2017 01:05:34 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8893A160B6D for ; Sat, 4 Mar 2017 02:05:33 +0100 (CET) Received: (qmail 8935 invoked by uid 500); 4 Mar 2017 01:05:32 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 8924 invoked by uid 99); 4 Mar 2017 01:05:32 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 04 Mar 2017 01:05:32 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 206CA1AA29E for ; Sat, 4 Mar 2017 01:05:32 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 7nUja3GkEE3A for ; Sat, 4 Mar 2017 01:05:31 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id ABE5F5FAD8 for ; Sat, 4 Mar 2017 01:05:30 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v2415P4e030696; Sat, 4 Mar 2017 01:05:25 GMT Message-Id: <201703040105.v2415P4e030696@ip-10-146-233-104.ec2.internal> Date: Sat, 4 Mar 2017 01:05:25 +0000 From: "Matthew Jacobs (Code Review)" To: Tim Armstrong , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Alex Behm Reply-To: mj@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4593=2CIMPALA-4635=3A_fix_some_python_build_issues=0A?= X-Gerrit-Change-Id: I9e807510eddeb354069e0478363f649a1c1b75cf X-Gerrit-ChangeURL: X-Gerrit-Commit: bae0b95bfae80ca87c3ee91ccf602104367fcc60 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Sat, 04 Mar 2017 01:05:34 -0000 Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4593,IMPALA-4635: fix some python build issues ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/6218/2/infra/python/bootstrap_virtualenv.py File infra/python/bootstrap_virtualenv.py: PS2, Line 90: process > It's a wrapper around popen defined on line 72 ah wow, right above this. thanks. was thrown off by this: https://pypi.python.org/pypi/exec_cmd http://gerrit.cloudera.org:8080/#/c/6218/3/infra/python/bootstrap_virtualenv.py File infra/python/bootstrap_virtualenv.py: PS3, Line 28: Every time this script is run nit: this makes it sound like this might be run multiple times http://gerrit.cloudera.org:8080/#/c/6218/3/infra/python/deps/download_requirements File infra/python/deps/download_requirements: PS3, Line 32: really nice to get rid of this, it was annoying ot have to change the kudu version in 2 places when upgrading -- To view, visit http://gerrit.cloudera.org:8080/6218 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e807510eddeb354069e0478363f649a1c1b75cf Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes