Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9B19C200C2C for ; Fri, 3 Mar 2017 22:37:32 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 99B59160B6D; Fri, 3 Mar 2017 21:37:32 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E369E160B5E for ; Fri, 3 Mar 2017 22:37:31 +0100 (CET) Received: (qmail 47779 invoked by uid 500); 3 Mar 2017 21:37:31 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 47768 invoked by uid 99); 3 Mar 2017 21:37:30 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Mar 2017 21:37:30 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 621CD1A034A for ; Fri, 3 Mar 2017 21:37:30 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id FFbxA6EZ1ScX for ; Fri, 3 Mar 2017 21:37:29 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id A16F55F4AC for ; Fri, 3 Mar 2017 21:37:28 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v23LbIrr021432; Fri, 3 Mar 2017 21:37:18 GMT Message-Id: <201703032137.v23LbIrr021432@ip-10-146-233-104.ec2.internal> Date: Fri, 3 Mar 2017 21:37:18 +0000 From: "Lars Volker (Code Review)" To: Matthew Jacobs , Tim Armstrong , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: lv@cloudera.com X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5Bnative-toolchain-CR=5D_Fix_setup_/_download_order_in_build_scripts=0A?= X-Gerrit-Change-Id: I287f091c8e772c08c8a61644d08117145b1ef16d X-Gerrit-ChangeURL: X-Gerrit-Commit: 04f75441e70c3215d459a65986acf1d9772c0c82 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Fri, 03 Mar 2017 21:37:32 -0000 Hello Matthew Jacobs, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6249 to look at the new patch set (#4). Change subject: Fix setup / download order in build scripts ...................................................................... Fix setup / download order in build scripts We need to download package sources before setting up the build environment for package builds. The naming of the 'header' function made it sound like it could be called before downloading the sources. This change fixes the places where the order was wrong and renames the header function to setup_package_build to make its name less confusing. Change-Id: I287f091c8e772c08c8a61644d08117145b1ef16d --- M build-kudu-only.sh M functions.sh M source/autoconf/build.sh M source/automake/build.sh M source/avro/build.sh M source/binutils/build.sh M source/boost/build.sh M source/breakpad/build.sh M source/bzip2/build.sh M source/cmake/build.sh M source/crcutil/build.sh M source/cyrus-sasl/build.sh M source/flatbuffers/build.sh M source/gcc/build.sh M source/gdb/build.sh M source/gflags/build.sh M source/glog/build.sh M source/googletest/build.sh M source/gperftools/build.sh M source/gtest/build.sh M source/kudu/build.sh M source/libev/build.sh M source/libevent/build.sh M source/libtool/build.sh M source/libunwind/build.sh M source/llvm/build-3.3.sh M source/llvm/build-source-tarball.sh M source/llvm/build.sh M source/lz4/build.sh M source/openldap/build.sh M source/openssl/build.sh M source/protobuf/build.sh M source/python/build.sh M source/rapidjson/build.sh M source/re2/build.sh M source/snappy/build.sh M source/thrift/build.sh M source/tpc-ds/build.sh M source/tpc-h/build.sh M source/zlib/build.sh 40 files changed, 190 insertions(+), 182 deletions(-) git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/49/6249/4 -- To view, visit http://gerrit.cloudera.org:8080/6249 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I287f091c8e772c08c8a61644d08117145b1ef16d Gerrit-PatchSet: 4 Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-Owner: Lars Volker Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong