Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 71552200C3A for ; Fri, 3 Mar 2017 05:37:44 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 6FD52160B7A; Fri, 3 Mar 2017 04:37:44 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B74D4160B6F for ; Fri, 3 Mar 2017 05:37:43 +0100 (CET) Received: (qmail 92586 invoked by uid 500); 3 Mar 2017 04:37:43 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 92575 invoked by uid 99); 3 Mar 2017 04:37:42 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Mar 2017 04:37:42 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 3AFB7C20EB for ; Fri, 3 Mar 2017 04:37:42 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id YBpixwNNQNki for ; Fri, 3 Mar 2017 04:37:41 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 70C9B5FDD4 for ; Fri, 3 Mar 2017 04:37:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v234beOe008935; Fri, 3 Mar 2017 04:37:40 GMT Message-Id: <201703030437.v234beOe008935@ip-10-146-233-104.ec2.internal> Date: Fri, 3 Mar 2017 04:37:40 +0000 From: "Zach Amsden (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Jim Apple , Dan Hecht Reply-To: zamsden@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-2020=3A_Inline_big_number_strings=0A?= X-Gerrit-Change-Id: I5095a366d914cebb0b64bd434a08dbb55c90ed30 X-Gerrit-ChangeURL: X-Gerrit-Commit: 72fed1b2d3c8046b15ebe5af569ca880e02ac2f8 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Fri, 03 Mar 2017 04:37:44 -0000 Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Inline big number strings ...................................................................... Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/5902/12/be/src/runtime/decimal-value.inline.h File be/src/runtime/decimal-value.inline.h: Line 42: // This means the multiplication can cause an unwanted decimal overflow. This comment was incorrect. The utility I was using to convert large numbers to binary apparently went through a double conversion itself somewhere, and truncated all binary numbers to the leading 53 bit representation, in turn leading me to believe we had precision available that was not utilized. -- To view, visit http://gerrit.cloudera.org:8080/5902 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5095a366d914cebb0b64bd434a08dbb55c90ed30 Gerrit-PatchSet: 12 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Zach Amsden Gerrit-HasComments: Yes