Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D3C3B200C3A for ; Fri, 3 Mar 2017 05:25:38 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id D282A160B7D; Fri, 3 Mar 2017 04:25:38 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 311B1160B6F for ; Fri, 3 Mar 2017 05:25:38 +0100 (CET) Received: (qmail 84541 invoked by uid 500); 3 Mar 2017 04:25:36 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 84529 invoked by uid 99); 3 Mar 2017 04:25:36 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Mar 2017 04:25:36 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 114DFC254D for ; Fri, 3 Mar 2017 04:25:36 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id OkNR4Ffeu2XV for ; Fri, 3 Mar 2017 04:25:34 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 7D64C5F23D for ; Fri, 3 Mar 2017 04:25:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v234PWLO008499; Fri, 3 Mar 2017 04:25:32 GMT Message-Id: <201703030425.v234PWLO008499@ip-10-146-233-104.ec2.internal> Date: Fri, 3 Mar 2017 04:25:31 +0000 From: "Lars Volker (Code Review)" To: Tim Armstrong , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: lv@cloudera.com X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5008=3A_Fix_reading_stats_for_TINYINT_and_SMALLINT=0A?= X-Gerrit-Change-Id: I9b10508db53747e7b08c8bd9a69c763b82135a78 X-Gerrit-ChangeURL: X-Gerrit-Commit: 16251aa7690efdc774b44827be9f8493ca0eb695 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Fri, 03 Mar 2017 04:25:39 -0000 Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6226 to look at the new patch set (#4). Change subject: IMPALA-5008: Fix reading stats for TINYINT and SMALLINT ...................................................................... IMPALA-5008: Fix reading stats for TINYINT and SMALLINT TINYINT and SMALLINT types use 1 and 2 byte slots respectively. However, statistics for the corresponding INT_8 and INT_16 Parquet types are encoded using 4 bytes. When reading back we were missing a conversion to the smaller types, thus overwriting the memory behind them. This was caught by the address sanitizer. The fix is to perform the necessary conversion. Change-Id: I9b10508db53747e7b08c8bd9a69c763b82135a78 --- M be/src/exec/parquet-column-stats.cc M be/src/runtime/coordinator.cc 2 files changed, 26 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/6226/4 -- To view, visit http://gerrit.cloudera.org:8080/6226 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9b10508db53747e7b08c8bd9a69c763b82135a78 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong