Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3C530200C2B for ; Thu, 2 Mar 2017 22:30:39 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 3ABF1160B6F; Thu, 2 Mar 2017 21:30:39 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8448D160B6A for ; Thu, 2 Mar 2017 22:30:38 +0100 (CET) Received: (qmail 75702 invoked by uid 500); 2 Mar 2017 21:30:37 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 75691 invoked by uid 99); 2 Mar 2017 21:30:37 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Mar 2017 21:30:37 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 1A50A180687 for ; Thu, 2 Mar 2017 21:30:37 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id z9iLjfOwrTDb for ; Thu, 2 Mar 2017 21:30:36 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 341335FB61 for ; Thu, 2 Mar 2017 21:30:36 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v22LUZso026447; Thu, 2 Mar 2017 21:30:35 GMT Message-Id: <201703022130.v22LUZso026447@ip-10-146-233-104.ec2.internal> Date: Thu, 2 Mar 2017 21:30:35 +0000 From: "Lars Volker (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Matthew Jacobs , David Knupp Reply-To: lv@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_Fix_parameter_order_in_test_mt_dop=2Epy=0A?= X-Gerrit-Change-Id: I925711eb4d4334c179d336f6ebcc91d26ce8879c X-Gerrit-ChangeURL: X-Gerrit-Commit: 02ecc81e46fc914a7cd9bf2791942edc90e59351 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Thu, 02 Mar 2017 21:30:39 -0000 Lars Volker has posted comments on this change. Change subject: Fix parameter order in test_mt_dop.py ...................................................................... Patch Set 1: (1 comment) Thanks for having a look. David, please see my reply to MJ's comment. http://gerrit.cloudera.org:8080/#/c/6228/1/tests/query_test/test_mt_dop.py File tests/query_test/test_mt_dop.py: Line 46: def test_compute_stats(self, vector, unique_database): > how do we know what is the 'right' order? what happens when it's not in the The order doesn't matter, since the calls use named parameters: test...(vector=..., unique_database=...). However this is the only place in our code base where the order is different, so I thought we may as well fix it. Maybe it'll prevent a bug in the future when someone calls the method from another test or so. -- To view, visit http://gerrit.cloudera.org:8080/6228 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I925711eb4d4334c179d336f6ebcc91d26ce8879c Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Matthew Jacobs Gerrit-HasComments: Yes