Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201703022123.v22LNwkY025761@ip-10-146-233-104.ec2.internal>
Date: Thu, 2 Mar 2017 21:23:58 +0000
From: "Lars Volker (Code Review)" <gerrit@cloudera.org>
To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org
CC: Tim Armstrong <tarmstrong@cloudera.com>,
        Marcel Kornacker <marcel@cloudera.com>,
        Alex Behm <alex.behm@cloudera.com>
Reply-To: lv@cloudera.com
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-2328=3A_Address_additional_comments=0A?=
In-Reply-To: <gerrit.1487973914000.I54c205fad7afc4a0b0a7d0f654859de76db29a02@gerrit.cloudera.org>
References: <gerrit.1487973914000.I54c205fad7afc4a0b0a7d0f654859de76db29a02@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.7
archived-at: Thu, 02 Mar 2017 21:24:13 -0000

Lars Volker has posted comments on this change.

Change subject: IMPALA-2328: Address additional comments
......................................................................


Patch Set 4:

(3 comments)

Thanks for the review, please see PS5.

http://gerrit.cloudera.org:8080/#/c/6147/4/be/src/exec/hdfs-parquet-scanner.cc
File be/src/exec/hdfs-parquet-scanner.cc:

Line 494:     // Resolve the parquet column using schema_resolver_. This will perform either name
> a short single line will suffice here (no need to say 'using schema_resolve
Done


Line 505:       // during the scan, so any predicate would evaluate to false. Return early.
> '<col> is null' would evaluate to true, did you cover that?
Yes, comparisons with null literals are filtered in the Frontend. min/max are only set when there are non-null values, so we don't consider statistics for "is null".


Line 512:       // In case there is a bug, we return an error, which will abort the query.
> sounds like this should also be a dcheck, no?
We abort in L515. I implemented it like this to re-use the error string for the status. Is there an easier way?


-- 
To view, visit http://gerrit.cloudera.org:8080/6147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I54c205fad7afc4a0b0a7d0f654859de76db29a02
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes