Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 405AE200C2B for ; Thu, 2 Mar 2017 08:02:27 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 3EF59160B6F; Thu, 2 Mar 2017 07:02:27 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 85E86160B61 for ; Thu, 2 Mar 2017 08:02:26 +0100 (CET) Received: (qmail 90667 invoked by uid 500); 2 Mar 2017 07:02:25 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 90655 invoked by uid 99); 2 Mar 2017 07:02:25 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Mar 2017 07:02:25 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 0C8A2188004 for ; Thu, 2 Mar 2017 07:02:25 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id gTkM85d7Ynlv for ; Thu, 2 Mar 2017 07:02:24 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 179625FD84 for ; Thu, 2 Mar 2017 07:02:24 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v2272N7o011740; Thu, 2 Mar 2017 07:02:23 GMT Message-Id: <201703020702.v2272N7o011740@ip-10-146-233-104.ec2.internal> Date: Thu, 2 Mar 2017 07:02:23 +0000 From: "Alex Behm (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Dimitris Tsirogiannis , Bharath Vissapragada Reply-To: alex.behm@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4998=3A_Fix_missing_table_lock_acquisition=2E=0A?= X-Gerrit-Change-Id: I0e0270daf59fce95f1a1520fc5aaf91d3a7b99fe X-Gerrit-ChangeURL: X-Gerrit-Commit: 2713f072b7884253e76c3b829b82a14ed65513bb In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Thu, 02 Mar 2017 07:02:27 -0000 Alex Behm has posted comments on this change. Change subject: IMPALA-4998: Fix missing table lock acquisition. ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/6177/5/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: PS5, Line 934: tbl instanceof IncompleteTable > Not related to this change but I believe we load the metadata twice if we c That's correct. It's a little tricky to fix because the first load is initiated during analysis of the REFRESH stmt, and then once we get into the CatalogOpExecutor the table should be loaded, so we would not load it again here in getOrLoadTable() (unless it got invalidated in the meantime). I think we need to re-think the FE analysis of REFRESH to fix it. This relates to some of the work Amos is doing. I filed IMPALA-5012. -- To view, visit http://gerrit.cloudera.org:8080/6177 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e0270daf59fce95f1a1520fc5aaf91d3a7b99fe Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-HasComments: Yes