Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6E8FB200C39 for ; Thu, 2 Mar 2017 03:11:51 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 6D11D160B82; Thu, 2 Mar 2017 02:11:51 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B8950160B70 for ; Thu, 2 Mar 2017 03:11:50 +0100 (CET) Received: (qmail 25343 invoked by uid 500); 2 Mar 2017 02:11:49 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 25330 invoked by uid 99); 2 Mar 2017 02:11:49 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Mar 2017 02:11:49 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 3D61918656D for ; Thu, 2 Mar 2017 02:11:49 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id VR7Mck3WhgNx for ; Thu, 2 Mar 2017 02:11:47 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 51CF55F36B for ; Thu, 2 Mar 2017 02:11:46 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v222BiX3007517; Thu, 2 Mar 2017 02:11:44 GMT Message-Id: <201703020211.v222BiX3007517@ip-10-146-233-104.ec2.internal> Date: Thu, 2 Mar 2017 02:11:44 +0000 From: "Joe McDonnell (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Lars Volker , Marcel Kornacker , Tim Armstrong Reply-To: joemcdonnell@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4899=3A_Fix_parquet_table_writer_dictionary_leak=0A?= X-Gerrit-Change-Id: I06e354086ad24071d4fbf823f25f5df23933688f X-Gerrit-ChangeURL: X-Gerrit-Commit: 7bcc2d9c6805cf66a02d64302bdb1b9a1eac97ef In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Thu, 02 Mar 2017 02:11:51 -0000 Joe McDonnell has posted comments on this change. Change subject: IMPALA-4899: Fix parquet table writer dictionary leak ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6181/4/be/src/exec/hdfs-table-sink.h File be/src/exec/hdfs-table-sink.h: Line 184: typedef std::pair, std::vector> PartitionPair; > to expand on that: your commit message explains the intention behind the un Improved comments here and in hdfs-parquet-table-writer.h. -- To view, visit http://gerrit.cloudera.org:8080/6181 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06e354086ad24071d4fbf823f25f5df23933688f Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes