Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5106B200C39 for ; Thu, 2 Mar 2017 01:20:01 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 4F965160B78; Thu, 2 Mar 2017 00:20:01 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 937DB160B70 for ; Thu, 2 Mar 2017 01:20:00 +0100 (CET) Received: (qmail 6626 invoked by uid 500); 2 Mar 2017 00:19:59 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 6615 invoked by uid 99); 2 Mar 2017 00:19:59 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Mar 2017 00:19:59 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 1FC72C05AA for ; Thu, 2 Mar 2017 00:19:59 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id TSBWUlAZKutL for ; Thu, 2 Mar 2017 00:19:58 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id B7C1E5F23D for ; Thu, 2 Mar 2017 00:19:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v220JtWn003851; Thu, 2 Mar 2017 00:19:55 GMT Message-Id: <201703020019.v220JtWn003851@ip-10-146-233-104.ec2.internal> Date: Thu, 2 Mar 2017 00:19:55 +0000 From: "Marcel Kornacker (Code Review)" To: Joe McDonnell , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Lars Volker , Tim Armstrong Reply-To: marcel@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4899=3A_Fix_parquet_table_writer_dictionary_leak=0A?= X-Gerrit-Change-Id: I06e354086ad24071d4fbf823f25f5df23933688f X-Gerrit-ChangeURL: X-Gerrit-Commit: 7bcc2d9c6805cf66a02d64302bdb1b9a1eac97ef In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Thu, 02 Mar 2017 00:20:01 -0000 Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4899: Fix parquet table writer dictionary leak ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6181/4/be/src/exec/hdfs-table-sink.h File be/src/exec/hdfs-table-sink.h: Line 184: typedef std::pair, std::vector> PartitionPair; please include updates to the class comments (of the affected classes) that briefly describe the memory management intentions. since we got this wrong last time around it appears to be subtle/non-obvious enough to warrant a description. -- To view, visit http://gerrit.cloudera.org:8080/6181 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06e354086ad24071d4fbf823f25f5df23933688f Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes