Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id F23CC200C2A for ; Wed, 1 Mar 2017 23:19:58 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id F0C6E160B70; Wed, 1 Mar 2017 22:19:58 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 45204160B56 for ; Wed, 1 Mar 2017 23:19:58 +0100 (CET) Received: (qmail 63392 invoked by uid 500); 1 Mar 2017 22:19:57 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 63381 invoked by uid 99); 1 Mar 2017 22:19:57 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Mar 2017 22:19:57 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id CB1391895B9 for ; Wed, 1 Mar 2017 22:19:56 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 8RzujBjBivPn for ; Wed, 1 Mar 2017 22:19:56 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 7EBCB5F306 for ; Wed, 1 Mar 2017 22:19:55 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v21MJop4030579; Wed, 1 Mar 2017 22:19:50 GMT Message-Id: <201703012219.v21MJop4030579@ip-10-146-233-104.ec2.internal> Date: Wed, 1 Mar 2017 22:19:50 +0000 From: "Tim Armstrong (Code Review)" To: Matthew Jacobs , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5Bnative-toolchain-CR=5D_IMPALA-5002=3A_Associate_toolchain_build_scripts/flags_with_built_packages=0A?= X-Gerrit-Change-Id: Ida6f1eee0c20de7fbfdbb716e5c7ac8686b558b6 X-Gerrit-ChangeURL: X-Gerrit-Commit: 42fb1510764370822681d660191791d28bfa7eb9 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Wed, 01 Mar 2017 22:19:59 -0000 Tim Armstrong has posted comments on this change. Change subject: IMPALA-5002: Associate toolchain build scripts/flags with built packages ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Seems like a good thing to track http://gerrit.cloudera.org:8080/#/c/6210/2/functions.sh File functions.sh: Line 351: git rev-parse HEAD > ${BUILD_DIR}/${PACKAGE_STRING}${PATCH_VERSION}/toolchain-build-hash.txt Long line -- To view, visit http://gerrit.cloudera.org:8080/6210 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida6f1eee0c20de7fbfdbb716e5c7ac8686b558b6 Gerrit-PatchSet: 2 Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes