Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0AA56200C2A for ; Wed, 1 Mar 2017 21:05:11 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 09270160B70; Wed, 1 Mar 2017 20:05:11 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4FBCC160B56 for ; Wed, 1 Mar 2017 21:05:10 +0100 (CET) Received: (qmail 15171 invoked by uid 500); 1 Mar 2017 20:05:09 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 15156 invoked by uid 99); 1 Mar 2017 20:05:09 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Mar 2017 20:05:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id DCFCC1A7B75 for ; Wed, 1 Mar 2017 20:05:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id n_4-uECwecTe for ; Wed, 1 Mar 2017 20:05:07 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id BFC4D5F254 for ; Wed, 1 Mar 2017 20:05:06 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v21K516d026738; Wed, 1 Mar 2017 20:05:01 GMT Message-Id: <201703012005.v21K516d026738@ip-10-146-233-104.ec2.internal> Date: Wed, 1 Mar 2017 20:05:01 +0000 From: "Alex Behm (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Bharath Vissapragada Reply-To: alex.behm@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4998=3A_Fix_missing_table_lock_acquisition=2E=0A?= X-Gerrit-Change-Id: I0e0270daf59fce95f1a1520fc5aaf91d3a7b99fe X-Gerrit-ChangeURL: X-Gerrit-Commit: 2713f072b7884253e76c3b829b82a14ed65513bb In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Wed, 01 Mar 2017 20:05:11 -0000 Alex Behm has posted comments on this change. Change subject: IMPALA-4998: Fix missing table lock acquisition. ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/6177/5/fe/src/main/java/org/apache/impala/catalog/TableLoadingMgr.java File fe/src/main/java/org/apache/impala/catalog/TableLoadingMgr.java: Line 318: if (tbl == null || tbl instanceof IncompleteTable || !tbl.isLoaded()) return; > Oops, I thought this was the actual code path for triggering refresh. Thank Yep. This code is weird and a little misleading :/ -- To view, visit http://gerrit.cloudera.org:8080/6177 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e0270daf59fce95f1a1520fc5aaf91d3a7b99fe Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Bharath Vissapragada Gerrit-HasComments: Yes