impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zach Amsden (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5132: Fix ASAN use after free in timezone db
Date Tue, 28 Mar 2017 22:18:15 GMT
Zach Amsden has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/6503

Change subject: IMPALA-5132: Fix ASAN use after free in timezone_db
......................................................................

IMPALA-5132: Fix ASAN use after free in timezone_db

The issue is that the string temporary returned by .string goes
out of scope immediately after being created.  Also, the API
to mkstemp is unclear on whether it modifies the string in place.
Just strdup() this to be safe - this is not performance critical
code.

Change-Id: I490f741403ea2004bc51394aa1251577337b1e1d
---
M be/src/exprs/timezone_db.cc
1 file changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/6503/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6503
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I490f741403ea2004bc51394aa1251577337b1e1d
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden <zamsden@cloudera.com>

Mime
View raw message