impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5031: Remove undefined behavior: left shift of negative values
Date Sun, 26 Mar 2017 15:07:42 GMT
Jim Apple has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/6491

Change subject: IMPALA-5031: Remove undefined behavior: left shift of negative values
......................................................................

IMPALA-5031: Remove undefined behavior: left shift of negative values

Left shift of negative values is undefined According to C++14 section
5.8 [expr.shift], paragraph 2.

Change-Id: I9d965c3950a878c0a41b374d51bbe2e5705b3360
---
M be/src/exec/read-write-util.cc
M be/src/exec/zigzag-test.cc
M be/src/exprs/bit-byte-functions-ir.cc
3 files changed, 6 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/6491/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6491
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9d965c3950a878c0a41b374d51bbe2e5705b3360
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbapple-impala@apache.org>

Mime
View raw message